Handle Adapter Type 53 and Undefined Types #56337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
twangboy
added
v3000.1
Ch3LL
approved these changes
Mar 11, 2020
DmitryKuzmenko
approved these changes
Mar 11, 2020
waynew
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for
NetworkAdapterType53. Also, if theNetworkAdapterTypeisn't in the Enumerated list of defined adapter types, use the adapter description instead of stack tracing.What issues does this PR fix or reference?
#56196
#56275
#56465
Previous Behavior
The NetworkInterfaceType enumeration from Microsoft doesn't include adapter type 53. The OpenVPN Tap interface returns a NetworkInterfaceType of 53, causing the util to stack trace and the minion not to start.
New Behavior
NetworkInterfaceType 53 now resolves to
TAPAdapter. Since AdapterType 53 may be an arbitrary number created by the OpenVPN driver it is arguable that other vendors may not use the same number. In which case the description will be used as the type.Tests written?
Yes
Commits signed with GPG?
Yes