Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boot VMs with UEFI GSoC #56613

Merged
merged 1 commit into from
Apr 13, 2020
Merged

boot VMs with UEFI GSoC #56613

merged 1 commit into from
Apr 13, 2020

Conversation

gqlo
Copy link
Contributor

@gqlo gqlo commented Apr 12, 2020

What does this PR do?

This PR adds support boot VMs with UEFI.

What issues does this PR fix or reference?

Fixes: a bug on removing existing boot parameters

Previous Behavior

Removing an existing boot parameters by passing an None object would fail. ElementTree.remove(parent_tag, tag) because ElementTree does not have a remove attribute.
Apart from that, we also need to make sure None object will not be passed to check_remote(orig_boot.get(key))

New Behavior

User is expected to specify loader and nvram with the corresponding firmware path to boot the VM with UEFI. For instance:

- boot:
     loader: /usr/share/OVMF/OVMF_CODE.fd
     nvram: /usr/share/OVMF/OVMF_VARS.ms.fd

To remove existing boot parameters, pass None object instead.

- boot:
     kernel: None
     initrd: None

Docs & changelog written?

Yes

  • Docs
  • Changelog

Tests written?

[NOTICE] Bug fixes or features added to Salt require tests.
Please review the test documentation for details on how to implement tests into Salt's test suite.

Yes

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@gqlo gqlo marked this pull request as ready for review April 12, 2020 05:39
@gqlo gqlo requested a review from a team as a code owner April 12, 2020 05:39
@ghost ghost requested a review from garethgreenaway April 12, 2020 05:39
@gqlo gqlo force-pushed the uefi-boot branch 3 times, most recently from 5d94cd1 to 9107877 Compare April 12, 2020 06:33
Copy link
Contributor

@dwoz dwoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MeAndTheFirefly Nice work, thanks for the contribution.

@dwoz dwoz merged commit 6a41478 into saltstack:master Apr 13, 2020
@gqlo
Copy link
Contributor Author

gqlo commented Apr 13, 2020

@MeAndTheFirefly Nice work, thanks for the contribution.
Thanks. :)

@cbosdo cbosdo mentioned this pull request Apr 24, 2020
@sagetherage sagetherage added the ZRelease-Sodium retired label label May 18, 2020
@sagetherage sagetherage added this to Done in Sodium May 19, 2020
@sagetherage sagetherage added this to PR needs merge to master in PRs to port to master via automation May 19, 2020
@sagetherage sagetherage moved this from PR needs merge to master to PR merged in PRs to port to master May 19, 2020
@gqlo gqlo mentioned this pull request May 22, 2020
3 tasks
@gqlo gqlo changed the title add support to boot VMs with UEFI add support to boot VMs with UEFI GSoC Aug 6, 2020
@gqlo gqlo changed the title add support to boot VMs with UEFI GSoC boot VMs with UEFI GSoC Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Sodium
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants