Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support boot VMs with UEFI.
What issues does this PR fix or reference?
Fixes: a bug on removing existing boot parameters
Previous Behavior
Removing an existing boot parameters by passing an None object would fail.
ElementTree.remove(parent_tag, tag)
because ElementTree does not have a remove attribute.Apart from that, we also need to make sure None object will not be passed to
check_remote(orig_boot.get(key))
New Behavior
User is expected to specify
loader
andnvram
with the corresponding firmware path to boot the VM with UEFI. For instance:To remove existing boot parameters, pass None object instead.
Docs & changelog written?
Yes
Tests written?
[NOTICE] Bug fixes or features added to Salt require tests.
Please review the test documentation for details on how to implement tests into Salt's test suite.
Yes
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.