Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve boot parameter documentation GSoC #57086

Merged
merged 1 commit into from
May 7, 2020
Merged

Conversation

gqlo
Copy link
Contributor

@gqlo gqlo commented May 5, 2020

What does this PR do?

This PR improves the boot parameter documentation. Parameter definitions are linked to virt.init function.

What issues does this PR fix or reference?

Fixes:
Fix some typos and spelling error in the doc.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

  • Docs
  • Changelog
  • Tests written/updated

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@gqlo gqlo requested a review from a team as a code owner May 5, 2020 14:02
@ghost ghost requested review from cmcmarrow and removed request for a team May 5, 2020 14:02
Copy link
Contributor

@cbosdo cbosdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a suggestion on how to make it better for the users and easier to handle for us later :)

salt/modules/virt.py Outdated Show resolved Hide resolved
salt/modules/virt.py Outdated Show resolved Hide resolved
salt/states/virt.py Outdated Show resolved Hide resolved
salt/states/virt.py Outdated Show resolved Hide resolved
cbosdo
cbosdo previously approved these changes May 6, 2020
Copy link
Contributor

@cbosdo cbosdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cbosdo
cbosdo previously approved these changes May 6, 2020
Copy link
Contributor

@cbosdo cbosdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should fix the doc error indeed

@cmcmarrow cmcmarrow added the Documentation Relates to Salt documentation label May 6, 2020
@dwoz dwoz merged commit 680abe9 into saltstack:master May 7, 2020
@sagetherage sagetherage added the ZRelease-Sodium retired label label May 18, 2020
@sagetherage sagetherage added this to Done in Sodium May 18, 2020
@gqlo gqlo changed the title improve boot parameter documentation improve boot parameter documentation GSoC Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Relates to Salt documentation ZRelease-Sodium retired label
Projects
No open projects
Sodium
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants