Memory Tuning GSoC#57636
Merged
Merged
Conversation
ghost
requested review from
cbosdo
previously approved these changes
Jun 11, 2020
cbosdo
left a comment
cbosdo
left a comment
Contributor
There was a problem hiding this comment.
A few cosmetic comments, but nothing serious. ACK
sagetherage
added
the
Feature
gqlo
force-pushed
the
memory_tune
branch
10 times, most recently
from
5fa3e80 to
7f066cf
Compare
gqlo
force-pushed
the
memory_tune
branch
6 times, most recently
from
bd6118d to
9018312
Compare
cbosdo
suggested changes
Sep 8, 2020
cbosdo
left a comment
cbosdo
left a comment
Contributor
There was a problem hiding this comment.
3 small things to improve still and we're good!
gqlo
force-pushed
the
memory_tune
branch
3 times, most recently
from
7a16ea4 to
924bebe
Compare
Contributor
|
@Akm0d could you review that PR? it should be good to go IMO |
Akm0d
approved these changes
Sep 8, 2020
Contributor
|
@dwoz could you merge this PR while it's ACKed, tests are green and doesn't need rebase yet? |
Contributor
Author
|
re-run all |
Akm0d
previously approved these changes
Sep 14, 2020
Contributor
|
@dwoz would be nice to have this PR merged before the freeze |
Akm0d
previously approved these changes
Sep 18, 2020
Contributor
|
re-run lint |
cbosdo
approved these changes
Sep 25, 2020
Contributor
|
@Akm0d can you approve that PR again? had to be rebased due to pre-commit hook changes. |
Akm0d
approved these changes
Sep 25, 2020
This was referenced Sep 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Feature request closes #57639
This PR makes memory tuning option available which allow much greater control of memory allocation. configurable parameters are:
hard_limitsoft_limitswap_hard_limitmin_guaranteeIn addition,
_handle_unitfunction is added which uses regex to parse user input into the corresponding size.Fixes a bug on adding sub element to existing XML tree.
Element.append()should be used to append an element into existing XML tree. When usingElementTree.SubElement()we must make sure the parent element is from the target domain XML tree.Refactored XML diff code, added a few helper functions to manipulate xml node.
More robust check is added
if 'initrd' in boot and boot.initrdto ensureNoneobject will not cause an exception if it is passed to initialise a new VM .Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.