Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 'OrderedDict' object has no attribute 'startswith' #58162

Conversation

remichristiaan
Copy link

Excluding an id when another state has a requisite depending on e.g.
a file that would be created by that excluded id/state. An exception is raised.

What does this PR do?

When excluding an id when another state has a requisite depending on e.g. a file that would be created by that excluded id/state. An exception is raised which does not give any hints what's wrong.

This fix will allow the (high)state run to finish and show the failed id(s) in the result.

What issues does this PR fix or reference?

Fixes: #57999

Previous Behavior

AttributeError: 'OrderedDict' object has no attribute 'startswith'

New Behavior

<snip>
----------
          ID: docker-restart
    Function: cmd.run
        Name: /bin/systemctl daemon-reload && /bin/systemctl restart docker.service
      Result: False
     Comment: The following requisites were not found:
                                 onchanges:
                                     file: /etc/systemd/system/docker.service.d/block-external-access.conf
     Started: 11:21:56.707274
    Duration: 0.015 ms
     Changes:

<snip>
Summary for myhost
-------------
Succeeded: 66 (unchanged=1)
Failed:     1
-------------
Total states run:     67
Total run time:   28.343 s

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

Excluding an id when another state has a requisite depending on e.g.
a file that would be created by that excluded id/state. An exception is raised.
@remichristiaan remichristiaan requested a review from a team as a code owner August 10, 2020 11:50
@ghost ghost requested review from Akm0d and removed request for a team August 10, 2020 11:50
Excluding an id when another state has a requisite depending on e.g.
a file that would be created by that excluded id/state. An exception is raised.
@remichristiaan
Copy link
Author

Unfortunately I do not have the time to setup my system for the pre-commit and lint stuff. Anyone that does, be my guest.

@Akm0d Akm0d added the help-wanted Community help is needed to resolve this label Aug 11, 2020
@dwoz dwoz added the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Sep 22, 2020
@sagetherage sagetherage requested review from xeacott and removed request for Akm0d March 5, 2021 23:56
@dwoz
Copy link
Contributor

dwoz commented Dec 10, 2023

Closing this due to inactivity. Anyone should feel free to re-open it if they want to see it through to the end in one release cycle.

@dwoz dwoz closed this Dec 10, 2023
@dwoz dwoz added the Abandoned label Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Abandoned has-failing-test help-wanted Community help is needed to resolve this Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 'OrderedDict' object has no attribute 'startswith' when using exclude with an id
4 participants