Invalidate file list cache when cache file has a future last modified time - #58529
Merged
Ch3LL merged 4 commits intoFeb 24, 2021
Merged
Conversation
Akm0d
previously approved these changes
Sep 23, 2020
meaksh
force-pushed
the
master-ignore-future-file-list-cache-file
branch
from
January 7, 2021 15:52
e7cb7f2 to
4c4dd17
Compare
meaksh
force-pushed
the
master-ignore-future-file-list-cache-file
branch
from
February 10, 2021 08:48
50d1c3d to
b6b9492
Compare
Contributor
Author
|
@Ch3LL @s0undt3ch this PR has been here for a while and it's ready to be merged. Would you mind to take a look? Thanks! |
s0undt3ch
approved these changes
Feb 23, 2021
Contributor
|
It's now properly tagged to go into the next major release. |
krionbsd
approved these changes
Feb 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an issue in
fileserver.check_file_list_cachewhich happens if the last modification time for the file list cache file is set to a future time.When this situation happens, the cache file is always taken and never* refreshed. Therefore, new files placed on the "file_roots" are not visible for the minions.
Previous Behavior
We see these logs and cache file is NOT refreshed:
New Behavior
We see these logs and cache file is refreshed:
Merge requirements satisfied?
Commits signed with GPG?
Yes