Invalidate file list cache when cache file has a future last modified time #58529
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an issue in
fileserver.check_file_list_cache
which happens if the last modification time for the file list cache file is set to a future time.When this situation happens, the cache file is always taken and never* refreshed. Therefore, new files placed on the "file_roots" are not visible for the minions.
Previous Behavior
We see these logs and cache file is NOT refreshed:
New Behavior
We see these logs and cache file is refreshed:
Merge requirements satisfied?
Commits signed with GPG?
Yes