Expose libvirt on_reboot in virt states #58591
Conversation
ghost
requested a review
from 
| @@ -254,3 +254,66 @@ def test_get_disk_convert_volumes(make_mock_vm, make_mock_storage_pool): | |||
| "virtual size": 214748364800, | |||
| }, | |||
| } == virt.get_disks("srv01") | |||
|
|
|||
|
|
|||
| def test_update_stop_on_reboot_reset(make_mock_vm): | |||
There was a problem hiding this comment.
Can we get some docstrings added to these tests?
|
re-run m2crypto |
cbosdo
force-pushed
the
on_reboot
branch
2 times, most recently
from
1db03d3
to
beb170e
Compare
|
Just rebased on master after the recent virt PR merge. |
|
@Ch3LL could you have a look at it now that your comment has been addressed and the PR is rebased? |
|
re-run pr-freebsd122-py3-pytest |
|
re-run pr-ubuntu2004-py3-pytest |
|
@dwoz can you merge this one now that it's rebased, green and ACKed? |
|
re-run pr-centos7-py3 |
It can be needed to force a VM to stop instead of rebooting. A typical example of this is when creating a VM using a install CDROM ISO or when using an autoinstallation profile. Forcing a shutdown allows libvirt to pick up another XML definition for the new start to remove the firstboot-only options.
Allow updating the definition of a VM without touching the live instance. This can be helpful since live update may change the device names in the guest.
While all virt.update properties default values should not be used when updating the XML definition, the stop_on_reboot default value (False) needs to be passed still or the user will never be able to update with this value.
|
re-run pr-windows2016-py3-pytest |
|
re-run pr-windows2019-py3-pytest |
|
@Akm0d @s0undt3ch could you review it again now that it's been rebased on master after solving the conflicts with another virt-related PR? Should be the last time for that PR though ;) |
|
@dwoz could you merge this PR? it's now rebased, ACKed and green |
|
re-run pr-macosxcatalina-py3-pytest |
|
re-run pr-ubuntu1604-py3-tcp-pytest |
|
re-run pr-freebsd122-py3-pytest |
|
re-run pr-centos8-py3-pytest |
What does this PR do?
This PR allows the user to force the VM to shutdown instead of rebooting. It also allows applying
virt.definedchanges only on the definition of a running instance rather than trying to apply the changes live.What issues does this PR fix or reference?
Fixes: #58589
Merge requirements satisfied?
Commits signed with GPG?
Yes