Fixes to inotify beacon #58655
Merged
Fixes to inotify beacon #58655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…notifications are fired the configuration fron the first beacon are used.
ghost
requested a review
from 
s0undt3ch
previously approved these changes
Oct 7, 2020
Ch3LL
previously approved these changes
Oct 7, 2020
|
@garethgreenaway This broke one of the inotify tests on many minions |
|
@twangboy Yup! Working on it. |
…core) from the beacon configuration. This is used when the beacons loop through the configuration, eg. status beacon, and expect certain options.
…ch goes in the configuration.
dwoz
approved these changes
Oct 8, 2020
meaksh
added a commit
to openSUSE/salt-packaging
that referenced
this pull request
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixing a use case when multiple inotify beacons are defined but when notifications are fired the configuration from the first beacon are used.
What issues does this PR fix or reference?
Fixes: #58616
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.