Use salt.utils.path.readlink to handle junctions on Windows #61326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynew
suggested changes
Dec 15, 2021
There was a problem hiding this comment.
This looks reasonable to me, but needs a changelog entry and test(s).
twangboy
force-pushed
the
fix_61170
branch
7 times, most recently
from
5436f8f
to
e75d627
Compare
twangboy
force-pushed
the
fix_61170
branch
3 times, most recently
from
7d1d693
to
fca0494
Compare
twangboy
force-pushed
the
fix_61170
branch
3 times, most recently
from
772aa83
to
9fb2572
Compare
Ch3LL
suggested changes
Jan 20, 2022
Add functional tests for the following: - file.readlink - file.replace - file.symlink Remove unit tests for file.replace as they are duplicated in the added functional test
twangboy
force-pushed
the
fix_61170
branch
2 times, most recently
from
dd8f268
to
b45d710
Compare
Ch3LL
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Attempts to handle the
readlinkfunction properly by using the salt util instead ofos.readlinkdirectly. Python 3.8 added support for directory junctions on Windows which prefixes the return with\\?\. The salt util strips that off and gives you back a clean path.Fixes: #61458
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes