- Exceptions apparently fire as original module rather than import-as #61906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkwilliams
force-pushed
the
tkwilliams_fix_mysql_mininon_cache
branch
from
dc60b22
to
a6979cf
Compare
|
OK, current v3004.1 is completely broken WRT minion cache, unrelated to this fix. This patch works on my older v3004, but v3004.1 is borked, with or without this patch. Closing this one - will submit a larger patch to resolve 3004.1 breakage along with this smaller fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves behaviour of #61417
While not a total fix -- which would involve entirely replacing the "retry 3 times" logic with something tunable, and back-off based -- this does at least fix the extant retry logic to work with both available MySQL python modules.