Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing slack engine when calling runners #63005

Merged

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Nov 3, 2022

What does this PR do?

swapping out args and kwargs for arg and kwarg respectively in the Slack engine when the command passed is a runner.

What issues does this PR fix or reference?

Fixes: #52400

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

…ack engine when the command passed is a runner.
@garethgreenaway garethgreenaway requested a review from a team as a code owner November 3, 2022 00:54
@garethgreenaway garethgreenaway requested review from waynew and removed request for a team November 3, 2022 00:54
@Ch3LL Ch3LL merged commit e7b3d59 into saltstack:master Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slack engine salt-run commands return exceptions
2 participants