[3006.x] Add more loader dunders to cp module. #65674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
dwoz
changed the title
Using cp module to dip our feet into more explicit loader dunders. Most all of the existing dunders can be imported already. The one outlier being used by the cp module is __opts__.
- Detect when a loader is returning a NamedLoaderContext and return the value. This will cut down on how often we need to call value() in loaded modules. - Add some tests to show newly defined behavior
dwoz
force-pushed
the
issue/3006.x/test_more_dunder
branch
from
28ba1c3
to
b478675
Compare
dwoz
changed the title
whytewolf
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using cp module to dip our feet into more explicit loader dunders. Most all of the existing dunders can be imported already. The one outlier being used by the cp module is opts.
What does this PR do?
What issues does this PR fix or reference?
Fixes:
Previous Behavior
Remove this section if not relevant
New Behavior
Remove this section if not relevant
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.