Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3006.x] Add more loader dunders to cp module. #65674

Merged
merged 7 commits into from
Apr 11, 2024
Merged

[3006.x] Add more loader dunders to cp module. #65674

merged 7 commits into from
Apr 11, 2024

Commits on Apr 8, 2024

  1. Add more loader dunders to cp module. 

    Using cp module to dip our feet into more explicit loader dunders. Most
all of the existing dunders can be imported already. The one outlier
being used by the cp module is __opts__.
    @dwoz
    dwoz committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    823a2aa View commit details
    Browse the repository at this point in the history

  2. Add tests for opts dunder

    @dwoz
    dwoz committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    488ffa1 View commit details
    Browse the repository at this point in the history

  3. Try importing opts dunder

    @dwoz
    dwoz committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    c669b1c View commit details
    Browse the repository at this point in the history

  4. Better handling of loader returns 

    - Detect when a loader is returning a NamedLoaderContext and return the
  value. This will cut down on how often we need to call value() in
  loaded modules.
- Add some tests to show newly defined behavior
    @dwoz
    dwoz committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    2eeb485 View commit details
    Browse the repository at this point in the history

  5. Fix broken tests

    @dwoz
    dwoz committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    a43fa58 View commit details
    Browse the repository at this point in the history

  6. Fix another test using __opts__

    @dwoz
    dwoz committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    6f78073 View commit details
    Browse the repository at this point in the history

  7. Fix windows pkg tests

    @dwoz
    dwoz committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    b478675 View commit details
    Browse the repository at this point in the history