Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plasma-b2c): processing "Text Field" view #244

Merged
merged 5 commits into from
Dec 22, 2022
Merged

feat(plasma-b2c): processing "Text Field" view #244

merged 5 commits into from
Dec 22, 2022

Conversation

Yakutoc
Copy link
Collaborator

@Yakutoc Yakutoc commented Nov 24, 2022 •
edited by Salute-Eva

🐤 Download canary assets:

colors--canary.244.3746513770.xml
color_metro_ios-swift--canary.244.3746513770.swift
color_metro_kotlin--canary.244.3746513770.kt
color_metro_react-native--canary.244.3746513770.ts
color_sbermarket_ios-swift--canary.244.3746513770.swift
color_sbermarket_kotlin--canary.244.3746513770.kt
color_sbermarket_react-native--canary.244.3746513770.ts
color_sberprime_ios-swift--canary.244.3746513770.swift
color_sberprime_kotlin--canary.244.3746513770.kt
color_sberprime_react-native--canary.244.3746513770.ts
color_selgros_ios-swift--canary.244.3746513770.swift
color_selgros_kotlin--canary.244.3746513770.kt
color_selgros_react-native--canary.244.3746513770.ts
color_smbusiness_ios-swift--canary.244.3746513770.swift
color_smbusiness_kotlin--canary.244.3746513770.kt
color_smbusiness_react-native--canary.244.3746513770.ts
PlasmaTokensColor--canary.244.3746513770.swift
typo_mage_kotlin--canary.244.3746513770.kt
typo_mage_react-native--canary.244.3746513770.ts
typo_plasma_kotlin--canary.244.3746513770.kt
typo_plasma_react-native--canary.244.3746513770.ts
typo_ruler_kotlin--canary.244.3746513770.kt
typo_ruler_react-native--canary.244.3746513770.ts
typo_sage_kotlin--canary.244.3746513770.kt
typo_sage_react-native--canary.244.3746513770.ts
typo_sbermarket_kotlin--canary.244.3746513770.kt
typo_sbermarket_react-native--canary.244.3746513770.ts
typo_soulmate_kotlin--canary.244.3746513770.kt
typo_soulmate_react-native--canary.244.3746513770.ts

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/plasma-b2c@1.121.0-canary.244.3746513770.0
# or 
yarn add @salutejs/plasma-b2c@1.121.0-canary.244.3746513770.0

@Salute-Eva
Copy link
Contributor

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-244/

New documentation 
http://plasma.fine.sberdevices.ru/pr/demo-canvas-app-pr-244/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr-244/
ui storybook: http://plasma.sberdevices.ru/pr-244/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr-244/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr-244/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr-244/temple-storybook/

New documentation 
website: http://plasma.fine.sberdevices.ru/pr/pr-244/
ui storybook: http://plasma.fine.sberdevices.ru/pr/pr-244/ui-storybook/
web storybook: http://plasma.fine.sberdevices.ru/pr/pr-244/web-storybook/
b2c storybook: http://plasma.fine.sberdevices.ru/pr/pr-244/b2c-storybook/
temple storybook: http://plasma.fine.sberdevices.ru/pr/pr-244/temple-storybook/

@Yakutoc Yakutoc force-pushed the lobyntseva/text-field-appearance branch from 52b77d5 to dba3743 Compare November 25, 2022 03:38
@Salute-Eva
Copy link
Contributor

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-244/

New documentation 
http://plasma.fine.sberdevices.ru/pr/demo-canvas-app-pr-244/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr-244/
ui storybook: http://plasma.sberdevices.ru/pr-244/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr-244/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr-244/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr-244/temple-storybook/

New documentation 
website: http://plasma.fine.sberdevices.ru/pr/pr-244/
ui storybook: http://plasma.fine.sberdevices.ru/pr/pr-244/ui-storybook/
web storybook: http://plasma.fine.sberdevices.ru/pr/pr-244/web-storybook/
b2c storybook: http://plasma.fine.sberdevices.ru/pr/pr-244/b2c-storybook/
temple storybook: http://plasma.fine.sberdevices.ru/pr/pr-244/temple-storybook/

@Yakutoc Yakutoc marked this pull request as ready for review November 25, 2022 04:18
@Yakutoc Yakutoc force-pushed the lobyntseva/text-field-appearance branch from dba3743 to d834662 Compare November 28, 2022 08:54
@Salute-Eva
Copy link
Contributor

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-244/

New documentation 
http://plasma.fine.sberdevices.ru/pr/demo-canvas-app-pr-244/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr-244/
ui storybook: http://plasma.sberdevices.ru/pr-244/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr-244/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr-244/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr-244/temple-storybook/

New documentation 
website: http://plasma.fine.sberdevices.ru/pr/pr-244/
ui storybook: http://plasma.fine.sberdevices.ru/pr/pr-244/ui-storybook/
web storybook: http://plasma.fine.sberdevices.ru/pr/pr-244/web-storybook/
b2c storybook: http://plasma.fine.sberdevices.ru/pr/pr-244/b2c-storybook/
temple storybook: http://plasma.fine.sberdevices.ru/pr/pr-244/temple-storybook/

@Yakutoc Yakutoc changed the title feat(plasma-b2c): processing "Text Field" appearance feat(plasma-b2c): processing "Text Field" view Nov 28, 2022
@Yakutoc Yakutoc force-pushed the lobyntseva/text-field-appearance branch from d834662 to ec7f211 Compare December 5, 2022 07:39
@Salute-Eva
Copy link
Contributor

Demo canvas app deployed!

http://plasma.sberdevices.ru/pr/demo-canvas-app-pr-244/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-244/
ui storybook: http://plasma.sberdevices.ru/pr/pr-244/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-244/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-244/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr/pr-244/temple-storybook/

@Yakutoc Yakutoc force-pushed the lobyntseva/text-field-appearance branch from ec7f211 to 3f484e6 Compare December 6, 2022 05:16
@Salute-Eva
Copy link
Contributor

Demo canvas app deployed!

http://plasma.sberdevices.ru/pr/demo-canvas-app-pr-244/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-244/
ui storybook: http://plasma.sberdevices.ru/pr/pr-244/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-244/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-244/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr/pr-244/temple-storybook/

@Yakutoc Yakutoc mentioned this pull request Dec 9, 2022
Open
Yeti-or
Yeti-or approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@Yeti-or Yeti-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В остальном ок

packages/plasma-core/src/components/TextField/TextField.component-test.tsx Outdated Show resolved Hide resolved
packages/plasma-core/src/components/TextField/TextField.component-test.tsx Show resolved Hide resolved
@Yakutoc Yakutoc force-pushed the lobyntseva/text-field-appearance branch from 3f484e6 to 190d451 Compare December 15, 2022 09:13
@Salute-Eva
Copy link
Contributor

Demo canvas app deployed!

http://plasma.sberdevices.ru/pr/demo-canvas-app-pr-244/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-244/
ui storybook: http://plasma.sberdevices.ru/pr/pr-244/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-244/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-244/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr/pr-244/temple-storybook/

@Yakutoc Yakutoc force-pushed the lobyntseva/text-field-appearance branch from 190d451 to c05e46a Compare December 16, 2022 08:51
@Salute-Eva
Copy link
Contributor

Demo canvas app deployed!

http://plasma.sberdevices.ru/pr/demo-canvas-app-pr-244/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-244/
ui storybook: http://plasma.sberdevices.ru/pr/pr-244/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-244/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-244/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr/pr-244/temple-storybook/

@Yakutoc Yakutoc force-pushed the lobyntseva/text-field-appearance branch from c05e46a to 53e039f Compare December 21, 2022 04:51
@Salute-Eva
Copy link
Contributor

Demo canvas app deployed!

http://plasma.sberdevices.ru/pr/demo-canvas-app-pr-244/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-244/
ui storybook: http://plasma.sberdevices.ru/pr/pr-244/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-244/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-244/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr/pr-244/temple-storybook/

@Yakutoc Yakutoc merged commit 8444674 into master Dec 22, 2022
@Yakutoc Yakutoc deleted the lobyntseva/text-field-appearance branch December 22, 2022 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yeti-or Yeti-or Yeti-or approved these changes

@neretin-trike neretin-trike neretin-trike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Yakutoc @Salute-Eva @Yeti-or @neretin-trike