feat(plasma-new-hope): refactor & add stretch/pin props #896

TitanKuzmich · 2023-12-06T16:59:02Z

Button

вынесены токены;
поправлено поведение props square;
добавлены недостающие props: stretch и pin

What/why changed

В рамках рефакторинга сделали важные изменения что бы код и дизайн был консистентным для всех библиотек.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/plasma-asdk@0.15.0-canary.896.7258736547.0
npm install @salutejs/plasma-b2c@1.256.0-canary.896.7258736547.0
npm install @salutejs/plasma-new-hope@0.22.0-canary.896.7258736547.0
npm install @salutejs/plasma-web@1.256.0-canary.896.7258736547.0
# or 
yarn add @salutejs/plasma-asdk@0.15.0-canary.896.7258736547.0
yarn add @salutejs/plasma-b2c@1.256.0-canary.896.7258736547.0
yarn add @salutejs/plasma-new-hope@0.22.0-canary.896.7258736547.0
yarn add @salutejs/plasma-web@1.256.0-canary.896.7258736547.0

Salute-Eva · 2023-12-06T17:04:36Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-896/

Salute-Eva · 2023-12-06T17:14:41Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-896/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-896/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-896/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-896/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-896/asdk-storybook/

Salute-Eva · 2023-12-07T08:09:33Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-896/

Salute-Eva · 2023-12-07T08:15:29Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-896/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-896/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-896/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-896/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-896/asdk-storybook/

packages/plasma-new-hope/src/utils/index.ts

packages/plasma-new-hope/src/components/Button/Button.tsx

neretin-trike · 2023-12-07T13:16:40Z

packages/plasma-new-hope/src/components/Button/Button.tsx

            </Root>
        );
    });

 export const buttonConfig = {
    name: 'Button',
-    tag: 'button',
+    tag: 'div',


но вообще прям не хочется рутовым элементом div держать :(

плюсую

@kayman233 комменты выше глянь пожалуйста

@Yeti-or @kayman233 вернуд button в root. Переменная с bprder-radius складывается в инлайн стили

kayman233 · 2023-12-13T13:56:32Z

packages/plasma-new-hope/src/components/Button/Button.tsx

            </Root>
        );
    });

 export const buttonConfig = {
    name: 'Button',
-    tag: 'button',
+    tag: 'div',


плюсую

packages/plasma-new-hope/src/components/Button/Button.types.ts

packages/plasma-new-hope/src/components/Button/tokens.ts

Salute-Eva · 2023-12-19T07:36:11Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-896/

Salute-Eva · 2023-12-19T07:42:31Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-896/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-896/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-896/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-896/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-896/asdk-storybook/

Salute-Eva · 2023-12-19T08:03:00Z

🚀 This PR is included in version: @salutejs/plasma-asdk@0.15.0-dev.0, @salutejs/plasma-b2c@1.256.0-dev.0, @salutejs/plasma-new-hope@0.22.0-dev.0, @salutejs/plasma-temple-docs@0.193.0-dev.0, @salutejs/plasma-ui-docs@0.242.0-dev.0, @salutejs/plasma-web-docs@0.210.0-dev.0, @salutejs/plasma-web@1.256.0-dev.0, @salutejs/plasma-website@0.218.0-dev.0 🚀

Salute-Eva · 2023-12-19T08:03:06Z

🚀 This PR is included in version: @salutejs/plasma-asdk@0.15.0-dev.0, @salutejs/plasma-b2c@1.256.0-dev.0, @salutejs/plasma-new-hope@0.22.0-dev.0, @salutejs/plasma-temple-docs@0.193.0-dev.0, @salutejs/plasma-ui-docs@0.242.0-dev.0, @salutejs/plasma-web-docs@0.210.0-dev.0, @salutejs/plasma-web@1.256.0-dev.0, @salutejs/plasma-website@0.218.0-dev.0 🚀

Salute-Eva · 2023-12-19T08:03:09Z

🚀 This PR is included in version: @salutejs/plasma-asdk@0.15.0-dev.0, @salutejs/plasma-b2c@1.256.0-dev.0, @salutejs/plasma-new-hope@0.22.0-dev.0, @salutejs/plasma-temple-docs@0.193.0-dev.0, @salutejs/plasma-ui-docs@0.242.0-dev.0, @salutejs/plasma-web-docs@0.210.0-dev.0, @salutejs/plasma-web@1.256.0-dev.0, @salutejs/plasma-website@0.218.0-dev.0 🚀

Salute-Eva · 2023-12-19T08:03:12Z

🚀 This PR is included in version: @salutejs/plasma-asdk@0.15.0-dev.0, @salutejs/plasma-b2c@1.256.0-dev.0, @salutejs/plasma-new-hope@0.22.0-dev.0, @salutejs/plasma-temple-docs@0.193.0-dev.0, @salutejs/plasma-ui-docs@0.242.0-dev.0, @salutejs/plasma-web-docs@0.210.0-dev.0, @salutejs/plasma-web@1.256.0-dev.0, @salutejs/plasma-website@0.218.0-dev.0 🚀

Salute-Eva · 2023-12-22T07:26:04Z

🚀 This PR is included in version: @salutejs/plasma-asdk@0.19.0, @salutejs/plasma-b2c@1.260.0, @salutejs/plasma-core@1.142.0, @salutejs/plasma-cy-utils@0.75.0, @salutejs/plasma-hope@1.250.0, @salutejs/plasma-icons@1.174.0, @salutejs/plasma-new-hope@0.26.0, @salutejs/plasma-sb-utils@0.140.0, @salutejs/plasma-temple-docs@0.197.0, @salutejs/plasma-temple@1.192.0, @salutejs/plasma-tokens-b2b@1.32.0, @salutejs/plasma-tokens-b2c@0.42.0, @salutejs/plasma-tokens-native@1.18.0, @salutejs/plasma-tokens-utils@0.36.0, @salutejs/plasma-tokens-web@1.47.0, @salutejs/plasma-tokens@1.67.0, @salutejs/plasma-ui-docs@0.246.0, @salutejs/plasma-ui@1.224.0, @salutejs/plasma-web-docs@0.214.0, @salutejs/plasma-web@1.260.0, @salutejs/plasma-website@0.222.0 🚀

TitanKuzmich requested review from Yeti-or, neretin-trike, Yakutoc and kayman233 as code owners December 6, 2023 16:59

TitanKuzmich temporarily deployed to internal December 6, 2023 16:59 — with GitHub Actions Inactive

TitanKuzmich removed the request for review from kayman233 December 6, 2023 16:59

TitanKuzmich self-assigned this Dec 6, 2023

TitanKuzmich added new-hope plasma-asdk labels Dec 6, 2023

TitanKuzmich added this to the Plasma: Refactoring & Redesign milestone Dec 6, 2023

TitanKuzmich temporarily deployed to internal December 7, 2023 08:07 — with GitHub Actions Inactive

neretin-trike reviewed Dec 7, 2023

View reviewed changes

packages/plasma-new-hope/src/utils/index.ts Outdated Show resolved Hide resolved

neretin-trike reviewed Dec 7, 2023

View reviewed changes

packages/plasma-new-hope/src/components/Button/Button.tsx Outdated Show resolved Hide resolved

neretin-trike reviewed Dec 7, 2023

View reviewed changes

TitanKuzmich requested a review from neretin-trike December 8, 2023 10:52

kayman233 reviewed Dec 13, 2023

View reviewed changes

TitanKuzmich requested a review from kayman233 December 14, 2023 07:51

TitanKuzmich force-pushed the plasma/add-button-features branch from 7bbd9d9 to c32036d Compare December 14, 2023 08:32

TitanKuzmich temporarily deployed to internal December 14, 2023 08:32 — with GitHub Actions Inactive

Yakutoc added plasma-components and removed plasma-asdk labels Dec 19, 2023

TitanKuzmich added 5 commits December 19, 2023 10:25

feat(plasma-new-hope): refactor & add stretch/pin props

dcfccbf

docs(plasma-asdk): regenerate api report

574a25b

feat(plasma-asdk): refactor button config & story

d1d51fa

feat(plasma-new-hope): add comments for button types

30537a2

feat(plasma-new-hope): revert button tag for root

f7f898a

TitanKuzmich force-pushed the plasma/add-button-features branch from 5cbf0b4 to f7f898a Compare December 19, 2023 07:33

TitanKuzmich temporarily deployed to internal December 19, 2023 07:33 — with GitHub Actions Inactive

TitanKuzmich added this pull request to the merge queue Dec 19, 2023

Merged via the queue into dev with commit 2416db6 Dec 19, 2023
25 checks passed

TitanKuzmich deleted the plasma/add-button-features branch December 19, 2023 07:51

Salute-Eva added the prerelease label Dec 19, 2023

This was referenced Dec 22, 2023

Release by 22.12.2023 #943

Closed

Release by 22.12.2023 #944

Merged

Yakutoc mentioned this pull request Dec 22, 2023

Release by 22.12.2023 #945

Merged

Salute-Eva added released and removed prerelease labels Dec 22, 2023

Salute-Eva mentioned this pull request Jan 18, 2024

Release by 18.01.2024 #972

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(plasma-new-hope): refactor & add stretch/pin props #896

feat(plasma-new-hope): refactor & add stretch/pin props #896

TitanKuzmich commented Dec 6, 2023 •

edited by Salute-Eva

Loading

Salute-Eva commented Dec 6, 2023

Salute-Eva commented Dec 6, 2023

Salute-Eva commented Dec 7, 2023

Salute-Eva commented Dec 7, 2023

neretin-trike Dec 7, 2023

kayman233 Dec 13, 2023

TitanKuzmich Dec 14, 2023

TitanKuzmich Dec 15, 2023

kayman233 Dec 13, 2023

Salute-Eva commented Dec 19, 2023

Salute-Eva commented Dec 19, 2023

Salute-Eva commented Dec 19, 2023

Salute-Eva commented Dec 19, 2023

Salute-Eva commented Dec 19, 2023

Salute-Eva commented Dec 19, 2023

Salute-Eva commented Dec 22, 2023

feat(plasma-new-hope): refactor & add stretch/pin props #896

feat(plasma-new-hope): refactor & add stretch/pin props #896

Conversation

TitanKuzmich commented Dec 6, 2023 • edited by Salute-Eva Loading

Button

What/why changed

Salute-Eva commented Dec 6, 2023

Salute-Eva commented Dec 6, 2023

Salute-Eva commented Dec 7, 2023

Salute-Eva commented Dec 7, 2023

neretin-trike Dec 7, 2023

Choose a reason for hiding this comment

kayman233 Dec 13, 2023

Choose a reason for hiding this comment

TitanKuzmich Dec 14, 2023

Choose a reason for hiding this comment

TitanKuzmich Dec 15, 2023

Choose a reason for hiding this comment

kayman233 Dec 13, 2023

Choose a reason for hiding this comment

Salute-Eva commented Dec 19, 2023

Salute-Eva commented Dec 19, 2023

Salute-Eva commented Dec 19, 2023

Salute-Eva commented Dec 19, 2023

Salute-Eva commented Dec 19, 2023

Salute-Eva commented Dec 19, 2023

Salute-Eva commented Dec 22, 2023

TitanKuzmich commented Dec 6, 2023 •

edited by Salute-Eva

Loading