New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exists is faster than checking value; typo #10

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@bieron
Contributor

bieron commented Jan 10, 2015

I considered writing tests but all I could think of was in reality testing code underneath, like Net::SFTP::Foreign for &stfp. So I settled for little things instead... really tried to find something more substantial :)

@salva

This comment has been minimized.

Show comment
Hide comment
@salva

salva Jan 11, 2015

Owner

Patch applied with changes.

Using exists in that code patch just to gain a few nanoseconds doesn't make sense, I prefer to have simpler code.

Owner

salva commented Jan 11, 2015

Patch applied with changes.

Using exists in that code patch just to gain a few nanoseconds doesn't make sense, I prefer to have simpler code.

@salva salva closed this Jan 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment