feat: custom resource #384
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thantos
reviewed
Jun 3, 2023
Comment on lines
+69
to
+70
| // This will need to be a ngrok URL when running locally | ||
| // And then the API Gateway URL when deployed |
There was a problem hiding this comment.
In .env
export const serviceUrl = () => tryGetEnv<string>(ENV_NAMES.SERVICE_URL);
thantos
reviewed
Jun 3, 2023
| smsUrl: process.env.SERVER_URL, | ||
| }); | ||
|
|
||
| export const sms = api.post("/sms", (request) => { |
There was a problem hiding this comment.
What is triggering this webhook? Is twillio asking for the SMS contents?
There was a problem hiding this comment.
Twilio will call this when a message is received. It needs to return the response
thantos
reviewed
Jun 3, 2023
Comment on lines
+65
to
+66
| // PROBLEM: attributes.sid won't exist during infer/synth | ||
| // can use a Proxy to intercept these references, not sure if good idea |
There was a problem hiding this comment.
Yeah, you'd need to load the data into an env variable and then pull the values out via a proxy. And then we'd either need to always inject every custom resource value into all functions or compute a dependency map.
Or you could do runtime lookups on demand to a SSM parameter, app config, or secret.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft experiment of implementing a custom resource primitive for CRUD lifecycle events implemented directly in eventual