Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local setup of UCI #34

Merged
merged 10 commits into from
Apr 18, 2023

Conversation

tushar5526
Copy link
Collaborator

@tushar5526 tushar5526 commented Apr 14, 2023

Related to fix in #23

  • Add UCI-admin to docker-compose and fix networking.
  • Add missing vars to .env

@tushar5526 tushar5526 marked this pull request as draft April 14, 2023 07:58
@gitguardian
Copy link

gitguardian bot commented Apr 14, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- SMTP credentials 7dde1c6 .env View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@tushar5526 tushar5526 mentioned this pull request Apr 14, 2023
27 tasks
.env Show resolved Hide resolved
.env Show resolved Hide resolved
.env Show resolved Hide resolved
.env Show resolved Hide resolved
.env Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
- Remove optional vars from .env
- Provide setup instruction for minio + fusionauth
- Add a docker-compose-debug which contains services for debug puposes
- Make each service to restart always
- Update env vars
@tushar5526
Copy link
Collaborator Author

Dependent on samagra-comms/uci-apis#61

@tushar5526
Copy link
Collaborator Author

@ChakshuGautam I have added a new manual-setup.sh and removed some steps of UCI setup as we have dockerized some services of the project. Moreover, starting all services at once, with restart:always policy.

@tushar5526 tushar5526 marked this pull request as ready for review April 18, 2023 04:44
@tushar5526 tushar5526 changed the title Fix Docker Compose Fix local setup of UCI Apr 18, 2023
@ChakshuGautam ChakshuGautam merged commit 958d7eb into samagra-comms:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants