Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements v2 #23

Closed
18 of 27 tasks
tushar5526 opened this issue Mar 28, 2023 · 11 comments
Closed
18 of 27 tasks

Improvements v2 #23

tushar5526 opened this issue Mar 28, 2023 · 11 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@tushar5526
Copy link
Collaborator

tushar5526 commented Mar 28, 2023

Fix:

Enhancements

Good to have

@ChakshuGautam
Copy link
Contributor

Actual env files that are required by every service

  1. Orchestrator
  2. Transformer

@karntrehan
Copy link
Contributor

Anvansh to pick up enhancements.

@RyanWalker277
Copy link
Collaborator

RyanWalker277 commented Apr 20, 2023

Marking the enhancements for which I have created a PR here. Still unable to link issues and PRs to the original checklist.

@susheelvar
Copy link

@tushar5526 to review these PRs and merging.

@susheelvar
Copy link

Previous PRs merged by @tushar5526

@RyanWalker277 to raise 1 PR today.

@RyanWalker277
Copy link
Collaborator

Previous PRs merged by @tushar5526

@RyanWalker277 to raise 1 PR today.

Raised the PR yesterday, synced dev with main and also completed work on some existing PRs and got them merged. Currently working on #58, since I am not that familiar with ODK, it might take a while to figure out the exact cause of the issue, will talk to @pankajjangid05 to figure out exact issue. Had a talk with yesterday with @tushar5526 and @chinmoy12c regarding the same.

@RyanWalker277
Copy link
Collaborator

There are 3 containers related to ODK, namely
aggregate-server : a tomcat container running odk
aggregate-db : postgres image
wait-for-db : waits for db to be up

The the aggregate-db container works fine. I can log in with the same creds as given in .env
image
Unable to replicate the issue at my end till now. Will look a bit deeper to replicate and solve this . Also, reached out to @pankajjangid05 on discord yesterday. Awaiting a response as of now

cc- @karntrehan @susheelvar

@RyanWalker277
Copy link
Collaborator

Had a talk with @tushar5526, the issue is with the aggregate-server, admin creds are not picked up from .env. Looking into it. Will send a patch soon.

@RyanWalker277
Copy link
Collaborator

PR raised on odk (samagra-comms/odk#6) for #58.

@susheelvar
Copy link

@tushar5526 to verify PR.

@karntrehan
Copy link
Contributor

Improvements are almost closed. @RyanWalker277 to present macro wins with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants