Update AKHQ username and password to be taken from .env #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tushar5526
reviewed
Apr 19, 2023
| @@ -14,8 +14,8 @@ services: | |||
| akhq: | |||
| security: | |||
| basic-auth: | |||
| - username: admin | |||
| password: d49745a74edfd20705ccaa277209db554b6b0d78c20780a4facf87e88aee78c0 | |||
| - username: ${AKHQ_USER} | |||
There was a problem hiding this comment.
Have you tested this locally? The last time I tried passwords were not picked properly.
There was a problem hiding this comment.
Yes they are being picked correctly.Checked it on local. Attaching a screenshot for refrence
There was a problem hiding this comment.
Try running the UI for this service, and check whether it is asking for authentication
There was a problem hiding this comment.
It's not asking for authentication, but even putting direct login creds, it's still failing to do so. I guess the problem is somwhere with the container configuration.
There was a problem hiding this comment.
Haan, figure it out then.
tushar5526
reviewed
Apr 20, 2023
tushar5526
requested changes
Apr 21, 2023
|
Let's pick it up after the env is refactored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37