Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Docker PullImage API is broken #66

Open
diptanu opened this issue Jan 14, 2015 · 3 comments
Open

Docker PullImage API is broken #66

diptanu opened this issue Jan 14, 2015 · 3 comments

Comments

@diptanu
Copy link

diptanu commented Jan 14, 2015

After the PR around better error message was merged into master, the PullImage API seems to be broken.

I am getting the following error message -

invalid character '{' after top-level value

when I am downloading an image from a private repository, for example - myregistry/busybox

My fork which was created before the PR #49 was merged works as expected - https://github.com/diptanu/dockerclient

@donhcd @vieux @samalba

@donhcd
Copy link
Collaborator

donhcd commented Jan 15, 2015

you're right - I assumed that the JSON objects would be newline-separated but that's unfortunately not true. I'm working on a PR to fix this

@donhcd
Copy link
Collaborator

donhcd commented Jan 15, 2015

@diptanu please take a look and see if this works for you ^ Parsing all of the json objects is pretty negligible compared to the network io, so I don't think there's anything wrong with me doing that.

@vieux
Copy link
Contributor

vieux commented Jan 17, 2015

I merged #66 because it fixed the issue for me.

@diptanu please confirm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants