This repository has been archived by the owner on Mar 18, 2024. It is now read-only.
Add better error handling for PullImage #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donhcd
force-pushed
the
betterPullError
branch
2 times, most recently
from
1ff55f7
to
11d35d0
Compare
donhcd
force-pushed
the
betterPullError
branch
from
11d35d0
to
1169320
Compare
|
ping @vieux @aluzzardi I added a test (partly copied from #57), and also I improved the response reading by using bufio.Scanner |
donhcd
force-pushed
the
betterPullError
branch
from
1169320
to
421e7bd
Compare
| } | ||
| defer resp.Body.Close() | ||
| scanner := bufio.NewScanner(resp.Body) | ||
| for scanner.Scan() { |
There was a problem hiding this comment.
@donhcd Do we really need to un-marshal every single line of response? I have always seen the error message to be on the last line of the response if the pull terminates with an error.
There was a problem hiding this comment.
you're right, the last line will have the error if there is one: https://github.com/docker/docker/blob/487a417d9fd074d0e78876072c7d1ebfd398ea7a/api/server/server.go#L518
I'll go ahead and make this change
donhcd
force-pushed
the
betterPullError
branch
from
421e7bd
to
3aa1d73
Compare
|
LGTM |
vieux
added a commit
that referenced
this pull request
Jan 9, 2015
Add better error handling for PullImage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.