This repository has been archived by the owner on Mar 18, 2024. It is now read-only.
Omit 0 ShmSize from HostConfig JSON to resolve compatibility issue with Docker 1.9.1 #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omitted, then shmsize will be set to Docker's default.
hrobertson
changed the title
|
lgtm |
|
LGTM |
|
Thank you 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Docker 1.9.1, an SHMSize of 0 is invalid and results in an error rather than being replaced by the default value.
In applications such as Drone that use dockerclient while not exposing all config values, this issue renders the application unusable with Docker 1.9.1.
In Docker >= 1.10 this is not an issue as the behaviour for an SHMSize of 0 is the same as nill (See acfd5eb). However, there are reasons for some people to be pinned to Docker 1.9.1 for the time being, eg when using Openshift.
I have not added tags to other fields as I wanted to limit the scope of this change to fixing this specific issue.
@crosbymichael, @vieux, @ehazlett
Thanks