Fixes #56 - Returning an error to the client if the image was not succes... #57
Conversation
…cessfully pulled
|
LGTM |
|
@samalba Thanks! Can this be merged now? |
|
@aluzzardi @vieux Could you have a quick look? |
| @@ -122,4 +135,5 @@ func TestContainerLogs(t *testing.T) { | |||
| t.Fatalf("expected stderr log line \"%s\" to end with \"%s\"", line, expectedSuffix) | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
nitpick: Why the extra empty line?
|
my pr #49 has the same goal. considering you've added tests and stuff, @diptanu maybe you could borrow my json unmarshalling code and add it into your pr? It looks at the |
|
@donhcd Sorry for the delayed response on this, as I am out on a vacation! Yeah, just looked at your PR and I have something similar now in terms of fetching the appropriate error message. One questions for @vieux and @samalba - Can I assume that every json literal would be delimited by Would love to make sure my assumptions are correct before I submit the updated PR. |
Hi,
I am sending a PR for the #56
I am checking for the presence of the word errorDetail in the response. Please let me know if there is a more efficient solution than this.