Skip to content

Commit

Permalink
workflows: now we can install directly via make/install-tools.sh use it
Browse files Browse the repository at this point in the history
Signed-off-by: John Mulligan <jmulligan@redhat.com>
  • Loading branch information
phlogistonjohn committed Apr 20, 2023
1 parent 0cbd952 commit ce38e55
Showing 1 changed file with 3 additions and 13 deletions.
16 changes: 3 additions & 13 deletions .github/workflows/container-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,20 +19,10 @@ jobs:
- uses: actions/checkout@v3
# We need a newer version of shellcheck to avoid problems with the
# relative imports. Our scripts work on v0.7.2 and up but not the
# v0.7.0 preinstalled in the ubutnu image
- name: Update shellcheck
run: |
shellcheck_version="v0.8.0"
url="https://github.com/koalaman/shellcheck/releases/download/${shellcheck_version}/shellcheck-${shellcheck_version}.linux.x86_64.tar.xz"
curl -Lo /tmp/shellcheck.tar.xz "$url"
mkdir /tmp/shellcheck
tar -xf /tmp/shellcheck.tar.xz -C /tmp/shellcheck
mkdir -p ~/bin
install -m0755 /tmp/shellcheck/shellcheck-${shellcheck_version}/shellcheck ~/bin/shellcheck
- name: Show shellcheck version
run: $HOME/bin/shellcheck --version
# v0.7.0 preinstalled in the ubutnu image. We can force a local
# install by expliclity setting SHELLCHECK to `$ALT_BIN/shellcheck`
- name: Run static check tools
run: make check SHELLCHECK=$HOME/bin/shellcheck
run: make check SHELLCHECK=$PWD/.bin/shellcheck

check-commits:
runs-on: ubuntu-latest
Expand Down

0 comments on commit ce38e55

Please sign in to comment.