workflows: add commitlint workflow #92
Conversation
obnoxxx
force-pushed
the
add-commitlint
branch
2 times, most recently
from
d581a94
to
8f877ad
Compare
|
strange, I don't see why the new workflow file does not trigger a check run ... 🤷♂️ |
component definitions are basically taken from the existing git log. Signed-off-by: Michael Adam <obnox@samba.org>
obnoxxx
force-pushed
the
add-commitlint
branch
from
8f877ad
to
fec5276
Compare
now it starts and even succeeds! 😄 |
obnoxxx
requested review from
anoopcs9,
gd,
phlogistonjohn,
spuiuk and
synarete
| @@ -0,0 +1,31 @@ | |||
| { | |||
There was a problem hiding this comment.
The recommended method is to use javascript config file. See: https://commitlint.js.org/#/reference-configuration
| "workflows", | ||
| "kubernetes", | ||
| "hack", | ||
| "Makefile" |
There was a problem hiding this comment.
We use makefile: (lowercase) labels so far. Better keep it that way.
| @@ -0,0 +1,26 @@ | |||
| name: Commitlint | |||
There was a problem hiding this comment.
Unlike rook, in samba-operator we use single workflow-action yaml, which allows us to see all jobs at once (as DAG) and halt workflow as soon a a job fails. Better have this section part of main.yaml with proper needs.
|
|
||
| jobs: | ||
| lint: | ||
| runs-on: ubuntu-18.04 |
| lint: | ||
| runs-on: ubuntu-18.04 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Why do you need this env? I think its redundant and confusing.
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| steps: | ||
| - uses: actions/checkout@v2 |
There was a problem hiding this comment.
Better use latest actions/checkout@v3
| steps: | ||
| - uses: actions/checkout@v2 | ||
| with: | ||
| fetch-depth: 0 |
There was a problem hiding this comment.
Why do you need this? AFAIK, it is not needed in this case.
| - uses: actions/checkout@v2 | ||
| with: | ||
| fetch-depth: 0 | ||
| - uses: wagoid/commitlint-github-action@v2.0.3 |
There was a problem hiding this comment.
Use latest version: wagoid/commitlint-github-action@v5
|
converted to draft becaus @phlogistonjohn suggested we solve the corresponding effort for samba-operator first : samba-in-kubernetes/samba-operator#272 or samba-in-kubernetes/samba-operator#274 |
|
Support for gitlint is already merged via #124. |
component definitions are basically taken from the existing git log.
Signed-off-by: Michael Adam obnox@redhat.com