Add gitlint support to samba-container #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rule `check-gitlint` can be run in order to see if commits on the current branch meet the basic requirements for the project. Signed-off-by: John Mulligan <jmulligan@redhat.com>
The check-commits job will help validate the commit messages on the commits included in a PR. Signed-off-by: John Mulligan <jmulligan@redhat.com>
anoopcs9
requested changes
Apr 21, 2023
This is similar, and inspired by, but not the same as, the install-tools.sh in samba-operator repo. Signed-off-by: John Mulligan <jmulligan@redhat.com>
I don't really like this but it matches the behavior of samba-operator while at the same time uses pattern matching so that future tools do not need a lot of boilerplate in the makefile for each instance. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
phlogistonjohn
force-pushed
the
jjm-gitlint
branch
from
ce38e55
to
a604d36
Compare
obnoxxx
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #121
I'm perfectly happy with the first commit in this series.
Everything including and after adding the 'install-tools.sh' I'm a bit iffy on. I tried multiple approaches and nothing pleased me. This current version is based on the workflow we have in samba-container where if the makefile determines a prerequisite tool is not present it tries to locally install one in the
.binsubdir under the repo root. Unlike the samba-operator version I tried really hard to avoid adding a lot of boilerplate to the makefie now and in the future and used some pattern matching to avoid it. Still, I'm not exactly thrilled with the implementation, but it was working OK for me.