Ntacls backup and restore #198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catalyst-joe-guo
force-pushed
the
ntacls_backup_and_restore
branch
3 times, most recently
from
c8ec5c3
to
b01db43
Compare
catalyst-joe-guo
force-pushed
the
ntacls_backup_and_restore
branch
3 times, most recently
from
42b932a
to
9d597ec
Compare
Add unlink api to delete a file with a smb connection. Test added. Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Add mkdir for smbd API. Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Extract initialization code from set_nt_acl_conn for reuse. Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Add create_file function to smbd API. Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
1. backup a share online from a smb connection with ntacls using pysmb API. 2. backup a share offline from service path with ntacls using pysmbd API. 3. restore from tarfile with pysmdb API. Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
catalyst-joe-guo
force-pushed
the
ntacls_backup_and_restore
branch
4 times, most recently
from
de2d317
to
b7a7d51
Compare
The ntacls backup tests have to run in ad_dc:local env, which is different from existing ntacls tests. Add a separate file for backup tests. Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Move acl and dommain_sid to global vars so we don't repeat them in every test. Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
catalyst-joe-guo
force-pushed
the
ntacls_backup_and_restore
branch
from
b7a7d51
to
ddc8b6d
Compare
|
Merged into master as 975b751 for Samba 4.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add following functions to samba.ntacls.py:
20180619 update:
To make these work, extended
pysmb.candpysmbd.c.Tests added in
samba.tests.ntacls.py.gitlab ci passed at:
https://gitlab.com/catalyst-samba/samba/pipelines/24028523