Adds possibility to change another user password #42
Conversation
|
Thanks. This (and samba-technical) is where we discuss patches, so you have indeed done the right thing. In terms of the actual patch, can you investigate if the same kind of modification could be made to samba-tool or net instead? smbpasswd is essentially frozen in time at this point, new functionality is added to our more general (and esaiser to expand) tools. In particular, this is because smbpasswd has enough of a non-standard command-line syntax as it is (inconsistent with the rest of samba, and getopt rather than popt based). Sorry, Andrew Bartlett |
|
The change is only on smbpasswd and is what I need. I didn't change any "out" function, so I guess they already have the correct prototype, but wasn't used correctly in smbpasswd. So that's why I changed it this way. |
|
So what will happen now ? I only updated smbpassd source code because other used libs' functions already fit what I needed. I don't see how I could do it differently... |
|
I understand it was the easiest to change, but we sadly can't accept such a patch to smbpasswd. The easiest patch to write is sadly often not the best patch for the project as a whole. I would suggest finding a way to patch 'samba-tool user password' to cover the auth/change user split you are after. It is a combination of python and C, but perhaps you can patch py_net_change_password in python/samba/netcmd/py_net.c and python/samba/netcmd/user.py to have such an option. |
|
I don't get it. Why should I update samba-tool when I'm using smbpasswd ? Is samba-tool going to replace smbpasswd ? |
|
Ok, as I understood it, samba-tool is the replacement of smbpasswd (or at least, does what smbpasswd did), so I'll update my patch in consequence. |
|
(Happy new year !). I added the change on smbpasswd as well. So now, each version is in its own commit. |
|
Any news on this pull request? |
|
Additionally, since the logon name has a maximum length your patch could be simplified. From https://technet.microsoft.com/it-it/library/bb726984%28en-us%29.aspx:
|
|
I wanted to make the change as little as possible but that seems to be a good idea. Thanks @aaptel! |
|
On Mon, 2016-01-18 at 02:20 -0800, Guillaume Gomez wrote:
This pull request isn't going anywhere, sorry. I know it isn't simple to patch our other tools, but smbpasswd is not Sorry, Andrew Bartlett Andrew Bartlett http://samba.org/~abartlet/ |
|
@abartlet: That's what I did in the second commit, I updated 'samba-tool'. If you want, I can remove the first one from the logs to allow you to take a simpler look. |
|
On Mon, 2016-01-25 at 02:37 -0800, Guillaume Gomez wrote:
Thanks. Patches to Samba need to be a series of 'perfect' commits - we Andrew Bartlett Andrew Bartlett http://samba.org/~abartlet/ |
|
Can somebody explain why the code in source4 needs to be altered when samba-tool already does what GuillaumeGomez is trying to do i.e. Set or reset the password of a user account. The command may be run from the root userid or another authorized userid. The I am not adverse to changes if they are required and helpful, but are they needed here ? |
|
I kept the first one to allow to easily understand what the second does (the version 4 of samba source code is very difficult to read and understand). Anyway, I removed the first commit, it only remains the source 4 commit. |
|
@hortimech: Hum... Is it really the same thing? I took a look and didn't find any "obvious" way to do the thing I was looking for (and as far as I know, it wasn't possible in version 3, and that's the original reason of this PR). |
|
As far as I am aware, the code in source4 is for Samba 4.x.x and samba-tool only works with Samba 4.x.x. I think you are also missing the fact that Samba 3.x.x is EOL. I have no idea if your code is good code or otherwise, I just don't want something changing for a corner case if this may adversely affect others. |
|
Well, it's your call. Just keep me up to date about your final decision please. |
|
you are right, that samba-tool is not currently the tool useful on Samba servers in "classic" mode, so your request for enhancing with a patch was not wrong. But I think the functionality is there already: as root you can just run "smbpasswd foo" and as a normal user you can change someone else's password with "smbpasswd -U foo". https://bugzilla.samba.org/ is the tool you shuld use to report bugs and feature requests, please use that next time. Thanks |
|
you're right, that samba-tool is not yet very useful for Samba servers in "classic" mode and your request to have that feature in smbpasswd is quite valid. But the feature is already implementen as far as I can see: as root you can run "smbpasswd foo" to set someone's password and as a user you can set someone else's password with "smbpasswd -U foo", can't you? https://bugzilla.samba.org/ is the right way to report bugs and feature requests for Samba, please use that in the future. Thanks |
Set "inherited" flag when winmsa changes ACL
I sent the patch to
contributing@samba.orgalready, but I'm not sure it's enough, so I post it here as well.