Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile #1

Open
sambhav2612 opened this issue Jul 4, 2018 · 6 comments
Open

Update Makefile #1

sambhav2612 opened this issue Jul 4, 2018 · 6 comments
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest Issue to be resolved under Hacktoberfest help wanted Extra attention is needed urgent The issue requires almost attention and urgent removal.

Comments

@sambhav2612
Copy link
Owner

sambhav2612 commented Jul 4, 2018

The current makefile is not working correctly. The intention of the script is to compile all .cpp files in every sub-directory from the root of the project. This is the output I'm currently getting in WIndows 10 with Cygwin environment:

$ make all
g++ -g -O -Wall  ./ch1-introduction ./ch10-sorting ./ch2-recursion-and-backtracking ./ch3-linked-lists ./ch4-stacks ./ch5-queues ./ch6-trees ./codechef/arrays -o all
./ch1-introduction: file not recognized: Is a directory
collect2: error: ld returned 1 exit status
Makefile:12: recipe for target 'all' failed
make: *** [all] Error 1

Please send PR to the update-makefile branch!

@sambhav2612 sambhav2612 added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers urgent The issue requires almost attention and urgent removal. labels Jul 4, 2018
@sambhav2612
Copy link
Owner Author

sambhav2612 commented Jul 4, 2018

I was using wildcard functions to accomplish the same, however, any different approach is more than welcome!

P.S. For reference - https://stackoverflow.com/questions/14028268/proper-method-for-wildcard-targets-in-gnu-make

@sambhav2612 sambhav2612 added the hacktoberfest Issue to be resolved under Hacktoberfest label Jul 5, 2018
@piba941
Copy link

piba941 commented Oct 1, 2018

@sambhav2612 i would like to take up this issue.

@sambhav2612
Copy link
Owner Author

Sure, go ahead @piba941!

@satyamroy001
Copy link

Any issues for me @sambhav2612 please tell me

@sambhav2612
Copy link
Owner Author

@satyamroy001 sure go ahead!

@satyamroy001
Copy link

satyamroy001 commented Oct 7, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest Issue to be resolved under Hacktoberfest help wanted Extra attention is needed urgent The issue requires almost attention and urgent removal.
Projects
None yet
Development

No branches or pull requests

3 participants