Skip properties that are not readable; Added unit test (#36)

sambitdash · Nov 11, 2018 · 17e8900 · 17e8900
1 parent c0c6a65
commit 17e8900
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 3 deletions.
diff --git a/src/PDDoc.jl b/src/PDDoc.jl
@@ -134,9 +134,13 @@ function pdDocGetInfo(doc::PDDoc)
     dInfo = Dict{CDTextString, Union{CDTextString, CDDate, CosObject}}()
     for (key, val) in get(obj)
         skey = CDTextString(key)
-        dInfo[skey] = (skey == "CreationDate") ||
-                      (skey == "ModDate") ? CDDate(val) :
-                      (skey == "Trapped") ? val : CDTextString(val)
+        try
+            dInfo[skey] = (skey == "CreationDate") ||
+                          (skey == "ModDate") ? CDDate(val) :
+                          (skey == "Trapped") ? val : CDTextString(val)
+        catch
+            # no op: we skipp the key that cannot be properly decoded
+        end
     end
     return dInfo
 end

diff --git a/test/files/empty_property.pdf b/test/files/empty_property.pdf
diff --git a/test/runtests.jl b/test/runtests.jl
@@ -69,6 +69,26 @@ include("debugIO.jl")
         end
     end
 
+    @testset "Document with empty property" begin
+        @test begin
+            filename="files/empty_property.pdf"
+            DEBUG && println(filename)
+            doc = pdDocOpen(filename)
+            DEBUG && println(pdDocGetCatalog(doc))
+            cosDoc = pdDocGetCosDoc(doc)
+            DEBUG && map(println, cosDoc.trailer)
+            info = pdDocGetInfo(doc)
+            @assert info == Dict(
+                "Producer" => "Scribus PDF Library 1.3.3.13",
+                "CreationDate" => CDDate("D:20090807192622"),
+                "ModDate" => CDDate("D:20090807192622"),
+                "Creator" => "Scribus 1.3.3.13",
+                "Trapped" => cn"False")
+            pdDocClose(doc)
+            length(utilPrintOpenFiles()) == 0
+        end
+    end
+
     @testset "PDF File with ObjectStreams" begin
         @test begin
             filename="files/pdf-17.pdf"