decode new shift-allowing format #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix an off-by-one in shift table one on the way
|
at least one bug still remains: MARTIAL ARTS UNIFORM ends up as MARTIAL ARTS UNJ and after that comes an empty name before CROISSANT. other than that i hope the decompressor struct and its "fill up the queue when we need stuff" approach is good. |
|
turns out we have 41 instead of 40 entries in the hash, but not in the list. that 41st entry is "FORM", which is what breaks the MARTIAL ARTS UNIFORM. so the .pop from the list is not enough (or we need to have it somewhere before the hash is built) |
|
that commit in there makes the MARTIAL ARTS UNIFORM work again :) |
|
and the performance improved nicely from |
when smart match against a type will do just as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix an off-by-one in shift table one on the way