Cache improvements #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
samdenty
commented
Oct 30, 2019
•
samdenty
commented
- Make Accessor#data static
- Reduce instantiation cost of classes
- Support keyed interfaces
- Support for circular keyed values
- Cache updates 3x as fast
🦋 Changeset is good to goLatest commit: 67d4ae1 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
=========================================
+ Coverage 75.31% 79.22% +3.9%
=========================================
Files 97 103 +6
Lines 1904 2012 +108
Branches 427 458 +31
=========================================
+ Hits 1434 1594 +160
+ Misses 462 409 -53
- Partials 8 9 +1
Continue to review full report at Codecov.
|
# Conflicts: # examples/react-github/package.json # examples/react-hackernews/package.json # gqless/package.json # gqless/src/utils/index.ts # packages/cli/README.md # packages/cli/package.json # packages/react/package.json # packages/schema/src/index.ts # packages/schema/src/schemaNodes.ts # packages/utils/package.json # packages/utils/src/createEvent.ts # packages/utils/src/index.ts # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.