Update gem and ruby versions to latest stable versions. #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove EOL ruby versions from travis: don't test unsupported versions. Add recent ruby versions: test current shipped and default versions.
berkes
force-pushed
the
feature-ruby-versions
branch
from
4283072
to
e75d709
Compare
This fixes a linting WARNING explaining these fields should be different. As per: https://guides.rubygems.org/specification-reference/#description
This fixes warnings from the gemspec linter
berkes
changed the title
This fixes samg#178.
Recent sequel did not support this, as it requires the table to exist on parsing the Model class. By extracting we also increase the Single Responsibility of the Models a bit.
This removes all rspec deprecation notices
berkes
changed the title
This was referenced Mar 9, 2020
|
amazing job, hope it gets merged |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove EOL ruby versions from travis: don't test unsupported versions.
Add recent ruby versions: test current shipped and default versions.