Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of string.format in namelist generator and repr #24

Merged
merged 5 commits into from
Feb 1, 2019

Conversation

jklenzing
Copy link
Member

Updates the string generation code for namelist and repr as part of #15.

Includes a fix for #22 to check if files exist before moving them. Currently prints to screen if there are no files to move. May want to change this to an error in the future.

@jklenzing jklenzing added the enhancement New feature or request label Feb 1, 2019
@jklenzing jklenzing self-assigned this Feb 1, 2019
@jklenzing jklenzing added this to To Do in User Interface Improvements via automation Feb 1, 2019
User Interface Improvements automation moved this from To Do to Approved Feb 1, 2019
Copy link
Collaborator

@JonathonMSmith JonathonMSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like where this is moving. I agree that the no files to move could be a warning or something in the future.

@jklenzing
Copy link
Member Author

At some point before the beta version is released we should plan out the level of error messages. Leaving it as print for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

2 participants