-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Review Queue Helper] Mod flag dialog autoclosing on single quote #40
Comments
No, I did mean single quote, here's line from userscript extension: Userscript header:
Screencap gif of issue: This script was the only one installed at time of recording and issue. Note, recorded on 4K screen so captures may be quite large and need scrolling, the issue occurs when ' is pressed even without the mod flag text field focused. Previously hadn't tested this, pressing the flag button followed by ' will close it immediately (You can ping me (NickA) in SO chat (SOCVR or Meta Room) for possibly faster responses). |
Userscript extension is Tampermonkey v4.8.41 |
Still unable to repro on Win 10 Chrome 76 and when it's the only script running, but I'll just add an ignore this particular single-quote key into the script |
This may be a keyboard issue, see below gif, when I enter ' it is captured as ~ and when I enter ~ it is captured as ' in Chrome (using the keyboard tester at https://www.keyboardtester.com/). Likely this'll be a non-issue but will investigate. Using a British keyboard with OS language settings set to English (UK). |
ahh, so tilde and single quote keycodes are swapped on the UK keyboard? I better not use tilde as a shortcut then :( |
thanks for reporting the issue, it should be fine now 👍 |
Worked a charm, thanks, I've opened a SU question to see if I can find the reason it's happening: https://superuser.com/questions/1472716/quote-is-detected-as-tilde-in-web-browsers-and-vice-versa |
Describe the bug
When writing a custom mod flag on a post pressing the single quote key (') closes the flag dialog.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The flag dialog doesn't close and the ' appears in the message
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: