-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various fixes making sure sockets and communication thread are terminated when requested (Changes Imported from UnrealNetImgui branch)
Missing Sample file changes
No longuer bundle previous version of Dear Imgui inside this depot. Now optionally fetch them from GitHub instead. Moved around some generated folders
…blished. NetImguiServer background now keeps its size ratio (instead of stretching) #11
…and changing some values)
…d of relying on Windows native WinSock2. Will allow easier porting of the server, to other platforms.
* Complete refactor of the UI. - Now using 'Dear ImGui' docking branch to render our UI and Client window. - Each client window can now be docked / moved around outside the main viewport. * Made it easier to port the server to other platforms - Networking now only uses our own platform independant API for communications - Rely on 'Dear ImGui' backend implementation for rendering, making it easy to switch to any supported platform - Input are now extracted from 'Dear ImGui' on the server and sent to client (instead of read directly from OS). - Few additional platform specific functions have been abstracted in a separate file and are easily identifiable. - Porting the server to other platform now means : Create makefile, select appropriate Dear Imgui backend, implement the few HAL_xxx functions
-Added support for refresh rate setting (with saved config value per client) -Connection stats (data transfer, ...) -Updated to a new bigger font setting -Added some missing namespace
Changed: Simplified Context management (does not create empty/clone context anymore) Changed: Improved: Transfer rate stats display Changed: display refresh rate only saved on Server setting (and configured as FPS) Fixed: Issue when resizing Sample window, not detecting font update Fixed: Server app not loading custom font Fixed: Server shutdown issue (delete client before communication were shutdown) Note: Might re-add cloned context support
Improved somes stats Moved Socket connection info to server HAL_xxxx functions, since only used by it, no need to have user implement it on each NetImgui_Network[platform].cpp
Added 'SampleSingleInclude' demonstrating how to only include this header to have all the sources compiled along Fixed the NetImguiServer application icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 1.3