Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step 2 — Set Babel’s IE target from 9 to 11 #3

Open
wants to merge 1 commit into
base: 01-preact
Choose a base branch
from

Conversation

sampi
Copy link
Owner

@sampi sampi commented Apr 22, 2018

We don't need to support IE8 & IE9 anymore…

This is how you can modify babel's target settings, not just IE ;)

The same way it was possible to change the webpack config, we're going to do just that to babel.

Files sizes remain the same because there are no 'fancy' methods used in the preact code so it compiles just the same on IE9 and IE11.

@sampi sampi force-pushed the 02-ie11 branch 2 times, most recently from e7c9d89 to 16a6b59 Compare April 22, 2018 12:08
@sampi sampi changed the title Step 2 - Set Babel’s IE target from 9 to 11 Step 2 — Set Babel’s IE target from 9 to 11 Apr 22, 2018
@@ -3,6 +3,10 @@
process.env.BABEL_ENV = 'production';
process.env.NODE_ENV = 'production';

const babelIE11 = require('./patch/babelIE11');
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The babel config needs to be patched before the webpack config, otherwise we're too late and it won't take effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant