Fix CQL Function Argument Hiding #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #835 +/- ##
===========================================
+ Coverage 93.87% 93.88% +0.01%
===========================================
Files 232 232
Lines 14633 14626 -7
Branches 383 384 +1
===========================================
- Hits 13736 13732 -4
+ Misses 514 510 -4
- Partials 383 384 +1
|
alexanderkiel
force-pushed
the
remove-single-scope
branch
from
817a535
to
bd8ef0c
Compare
I added CQL functions in #501. Function arguments are added to the scope. However in queries, I had an optimization that overrode the scope with a single value if the scope was empty. The problem was that I did not pay attention to the function argument scope. To keeps things simple, I just removed the optimization.
alexanderkiel
force-pushed
the
remove-single-scope
branch
from
bd8ef0c
to
7903fba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added CQL functions in #501. Function arguments are added to the scope. However in queries, I had an optimization that overrode the scope with a single value if the scope was empty. The problem was that I did not pay attention to the function argument scope. To keeps things simple, I just removed the optimization.