Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11 does'nt seem to like relative iconUrl's in plyr.setup #269

Closed
Joolyan opened this issue Jun 8, 2016 · 6 comments
Closed

IE11 does'nt seem to like relative iconUrl's in plyr.setup #269

Joolyan opened this issue Jun 8, 2016 · 6 comments

Comments

@Joolyan
Copy link

Joolyan commented Jun 8, 2016

After reviewing many other media players, I'm really enjoying playing with Plyr. Thanks for sharing.

I'm not a developer, so I'm not sure if the following is an issue limited to novice users like myself.

If iconUrl (in plyr.setup) is given a relative URL (such as dist/plyr.svg) the icons don't render correctly in IE11. However, using a full URL (such as https://cdn.plyr.io/1.6.19/plyr.svg) seems to resolve the issue.

I see you've just updated to version 1.7.0 which I believe still shares the same issue.

Thanks again.

@Joolyan
Copy link
Author

Joolyan commented Jun 9, 2016

Wow...
Fixed using a relative URL for iconUrl in IE (fixes #269)

I've not had time to test, but just wanted to say 'Thanks'.

@sampotts
Copy link
Owner

sampotts commented Jun 9, 2016

No worries - sorry, I forgot to actually reply to the issue. 👍

@Joolyan
Copy link
Author

Joolyan commented Jun 10, 2016

Unfortunately I can still reproduce this issue...

Download
https://plyr.io/index.html
https://cdn.plyr.io/1.8.2/demo.js
https://cdn.plyr.io/1.8.2/demo.svg
https://cdn.plyr.io/1.8.2/plyr.svg

Edit index.html to use downloaded version of demo.js
replace "<script src="https://cdn.plyr.io/1.8.2/demo.js"></script>"
with "<script src="demo.js"></script>"

Edit demo.js to use downloaded versions of plyr.svg and demo.svg (using full URLs)
replace "https://cdn.plyr.io/1.8.2/plyr.svg" with "http://plyr.192.168.1.11.xip.io/test/plyr.svg"
replace "https://cdn.plyr.io/1.8.2/demo.svg" with "http://plyr.192.168.1.11.xip.io/test/demo.svg"

NB. Testing using a MacBook with vmWare Fusion, pow.cx and xip.io

IE11 renders Plyr controls correctly. No issues

Now edit demo.js to local relative URLs
replace "http://plyr.192.168.1.11.xip.io/test/plyr.svg" with "plyr.svg"
replace "http://plyr.192.168.1.11.xip.io/test/demo.svg" with "demo.svg"

The demo.svg renders correctly, but the Plyr controls don't.

Hope this helps?
Please let me know if I should have open a new issue?

@sampotts
Copy link
Owner

OK I'll take another look

@sampotts sampotts reopened this Jun 12, 2016
@sampotts
Copy link
Owner

Think I've nailed it now 👍

@sampotts sampotts reopened this Jun 25, 2016
@Joolyan
Copy link
Author

Joolyan commented Jun 30, 2016

You've nailed it. Just tested v1.8.7 and the issue with IE11 is fixed.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants