-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE11 does'nt seem to like relative iconUrl's in plyr.setup #269
Comments
Wow... I've not had time to test, but just wanted to say 'Thanks'. |
No worries - sorry, I forgot to actually reply to the issue. 👍 |
Unfortunately I can still reproduce this issue... Download Edit index.html to use downloaded version of demo.js Edit demo.js to use downloaded versions of plyr.svg and demo.svg (using full URLs) NB. Testing using a MacBook with vmWare Fusion, pow.cx and xip.io IE11 renders Plyr controls correctly. No issues Now edit demo.js to local relative URLs The demo.svg renders correctly, but the Plyr controls don't. Hope this helps? |
OK I'll take another look |
Think I've nailed it now 👍 |
You've nailed it. Just tested v1.8.7 and the issue with IE11 is fixed. |
After reviewing many other media players, I'm really enjoying playing with Plyr. Thanks for sharing.
I'm not a developer, so I'm not sure if the following is an issue limited to novice users like myself.
If iconUrl (in plyr.setup) is given a relative URL (such as dist/plyr.svg) the icons don't render correctly in IE11. However, using a full URL (such as https://cdn.plyr.io/1.6.19/plyr.svg) seems to resolve the issue.
I see you've just updated to version 1.7.0 which I believe still shares the same issue.
Thanks again.
The text was updated successfully, but these errors were encountered: