Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight more in JS #3

Closed
WandersonAlves opened this issue Jul 5, 2018 · 2 comments
Closed

Highlight more in JS #3

WandersonAlves opened this issue Jul 5, 2018 · 2 comments

Comments

@WandersonAlves
Copy link

Hi, first of all I would like to say that I loved your theme!
The colors are awesome!

If possible, can you make function names declarations this keyword, decorators declarations and objects attributes of js, vue, ts, tsx, jsx files to be highlighted?

Currently in a vue file, your theme behave like below

screenshot from 2018-07-05 14-11-51

In ts files, your theme behave like below

screenshot from 2018-07-05 14-15-05

And the screenshot below is from cobalt2 theme that have everything highlighted

screenshot from 2018-07-05 14-16-16

Thanks dude!

@WandersonAlves
Copy link
Author

Oh, and i saw on #2 that someone posted his configs about italic words, so here is mine:

"editor.tokenColorCustomizations": {
        "textMateRules": [
            {
                "scope": [
                    "comment",
                    "keyword",
                    "constant",
                    "storage.modifier",
                    "storage.type.class.js",
                ],
                "settings": {
                    "fontStyle": "italic",
                }
            },
            {
                "scope": [
                    "invalid",
                    "keyword.operator",
                    "constant.numeric.css",
                    "keyword.other.unit.px.css",
                    "constant.numeric.decimal.js",
                    "constant.numeric.json"
                ],
                "settings": {
                    "fontStyle": ""
                }
            }
        ]
    },

@samrap
Copy link
Owner

samrap commented Jul 5, 2018

As I mentioned in #2 , I will be going through the color scheme for various languages (including JS) with a fine-toothed comb over the next few weeks. While I do plan on improving the highlighting of various keywords, I do not plan on making this theme as colorful as something like cobalt. My goal with this theme is to be more minimal, using only the bright synthwave color palette on the more important scopes. Stay tuned over the next few weeks as I push updates, but I am going to close this issue for now and open a new one that references this. Thanks for trying out the theme!

@samrap samrap closed this as completed Jul 5, 2018
@samrap samrap mentioned this issue Jul 5, 2018
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants