Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Javascript: Italicize more words #2

Closed
Vorror opened this issue Jun 30, 2018 · 6 comments
Closed

[Feature Request] Javascript: Italicize more words #2

Vorror opened this issue Jun 30, 2018 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@Vorror
Copy link

Vorror commented Jun 30, 2018

Feature Request:

Currently, certain javascript keywords aren't italicized (this, super, extends). Could outrun be updated to support them?

screen shot 2018-06-30 at 11 44 45 am

For example, the "RED" theme does this correctly(except extends)

screen shot 2018-06-30 at 11 50 39 am

p.s Found your theme on reddit. Great job :)

@samrap
Copy link
Owner

samrap commented Jul 1, 2018

Glad you're trying it out :)

I can definitely do this. I will look into a couple themes that have better JS configs and get some more italics where appropriate.

@samrap samrap added the enhancement New feature or request label Jul 1, 2018
@samrap samrap self-assigned this Jul 1, 2018
@Vorror
Copy link
Author

Vorror commented Jul 1, 2018

@samrap Thanks!

Currently I'm using, which works for me

 "editor.tokenColorCustomizations": {
        "[Outrun]": {
            "textMateRules": [
                {
                    "scope": [
                        "variable.language.this.js",
                        "variable.language.super.js"
                    ],
                    "settings": {
                        "foreground": "#F4B80C",
                        "fontStyle": "italic"
                    }
                }
            ]
        }
    }

@samrap
Copy link
Owner

samrap commented Jul 2, 2018

Thanks for sharing that. I'll take a look at it tomorrow and get it published early this week :)

@samrap samrap closed this as completed in 0e9c926 Jul 2, 2018
@samrap
Copy link
Owner

samrap commented Jul 2, 2018

@Vorror Update has been made and tagged at 0.0.2. I went with cyan for the keyword foreground. I have a lot of cleaning up to do for JavaScript and some of the global syntax colors as I start to use this more and the cyan will look best after the next version update.

@Vorror
Copy link
Author

Vorror commented Jul 2, 2018

@samrap You're awesome :) I removed my setting. I think cyan looks a lot better.

I had a full work day with your theme and it's awesome. The only other thing I changed was the tabs:
screen shot 2018-07-02 at 7 37 02 pm

I noticed it took me 1-2 seconds longer than normal to find the active tab so I made the above change. It's definitely a very personal preference. Now I'm always aware of the current tabs position when it's in my periphery. And I think it looks a bit better than the gray bar between the tabs.

@samrap
Copy link
Owner

samrap commented Jul 2, 2018

I'm digging those tabs. I'll be sure to add that in on the next version.

As I said, this hasn't been used much by me in the wild (this is actually my first week using it too), so needless to say there's a lot of fine-tuning to do. I'm also brand-new to VS Code itself, so there's probably a lot features I haven't tested the theme in yet.

Super stoked to hear you're liking it, you can expect some subtle clean-up over the next few weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants