Skip to content
This repository has been archived by the owner on Feb 15, 2023. It is now read-only.

diff key must be scalar #190

Merged
merged 3 commits into from
Oct 19, 2018
Merged

diff key must be scalar #190

merged 3 commits into from
Oct 19, 2018

Commits on Oct 16, 2018

  1. go vendor: fetch github.com/samsarahq/go/oops

    @changpingc
    changpingc committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    28532af View commit details
    Browse the repository at this point in the history

  2. go schemabuilder: enforce key must be scalar 

    Key is used to match objects in diff & merge. We require keys
to be comparable in golang. If we serialize and then deserialize
a struct key without strong typing, it becomes map[string]interface{},
which is no longer comparable. Therefore, we want to enforce
a stronger requirement that keys are scalar, such as ints and strings.
    @changpingc
    changpingc committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    2c97ca1 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2018

  1. changelog: require object key to be scalar

    @changpingc
    changpingc committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    57c4fc5 View commit details
    Browse the repository at this point in the history