This repository has been archived by the owner on Feb 15, 2023. It is now read-only.
diff key must be scalar #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Key is used to match objects in diff & merge. We require keys
to be comparable in golang. If we serialize and then deserialize
a struct key without strong typing, it becomes map[string]interface{},
which is no longer comparable. Therefore, we want to enforce
a stronger requirement that keys are scalar, such as ints and strings.
zdylag
reviewed
Oct 17, 2018
|
vendor oops because #186 didn't |
|
i'd feel okay not vendoring it still
…On Wed, Oct 17, 2018 at 6:05 PM, Changping Chen ***@***.***> wrote:
vendor oops because #186 <#186>
didn't
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#190 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACNp-hBkD-NrbT_Zb3la2WsDM84B3lwZks5ul9PdgaJpZM4XilM9>
.
|
|
@stephen not vendoring breaks go test |
changpingc
force-pushed
the
changping/diff-key
branch
from
1937ab2
to
57c4fc5
Compare
Pull Request Test Coverage Report for Build 1166
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits. I added some unit tests.