This repository has been archived by the owner on Feb 15, 2023. It is now read-only.
btuan/count #230
Merged
btuan/count #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1365
💛 - Coveralls |
ryanr23
reviewed
Mar 29, 2019
ryanr23
reviewed
Mar 29, 2019
btuan
force-pushed
the
btuan/count
branch
2 times, most recently
from
3f31e7c
to
cca032a
Compare
berfarah
reviewed
Mar 29, 2019
|
hype |
btuan
force-pushed
the
btuan/count
branch
2 times, most recently
from
095d98d
to
dfc6b16
Compare
berfarah
reviewed
Mar 29, 2019
berfarah
approved these changes
Mar 30, 2019
There was a problem hiding this comment.
From offline chat:
Trade-off is being consistent with the code-base as is vs making this library easy to maintain going forward. I favor the latter by exporting as little as possible so we can change things around if we need to. In this case, that means exporting a SQLQuery interface.
|
I plan on merging this Monday, barring any additional comments! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a basic
Countreceiver that wrapsSELECT COUNT(*)functionality in SQL databases.