Skip to content
This repository has been archived by the owner on Feb 15, 2023. It is now read-only.

*: remove opentracing #77

Merged
merged 1 commit into from
Feb 6, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 0 additions & 36 deletions opentracingkit/opentracingkit.go

This file was deleted.

34 changes: 1 addition & 33 deletions sqlgen/db.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,8 @@ import (
"context"
"database/sql"
"errors"
"fmt"

"github.com/samsarahq/thunder/batch"
"github.com/samsarahq/thunder/opentracingkit"
)

// DB uses a *sql.DB connection that is established by its owner. DB assumes the
Expand All @@ -30,9 +28,6 @@ func NewDB(conn *sql.DB, schema *Schema) *DB {
Many: func(ctx context.Context, items []interface{}) ([]interface{}, error) {
table := items[0].(*BaseSelectQuery).Table

span, ctx := opentracingkit.MaybeStartSpanFromContext(ctx, fmt.Sprintf("thunder.sqlgen.BatchQuery(%s)", table.Name))
defer span.Finish()

// First, build the SQL query.
filters := make([]Filter, 0, len(items))
for _, item := range items {
Expand All @@ -51,22 +46,17 @@ func NewDB(conn *sql.DB, schema *Schema) *DB {
return nil, err
}
clause, args = selectQuery.ToSQL()
span.SetTag("query", clause)
span.SetTag("batchItemCount", len(items))
span.SetTag("queryVariables", args)

// Then, run the SQL query.
res, err := db.Conn.Query(clause, args...)
if err != nil {
opentracingkit.LogError(span, err)
return nil, err
}
defer res.Close()
rows, err := db.Schema.ParseRows(selectQuery, res)
if err != nil {
return nil, err
}
span.SetTag("batchResultCount", len(rows))

// Finally, match the returned rows against the queries.
matcher := newMatcher()
Expand Down Expand Up @@ -118,14 +108,8 @@ func (db *DB) BaseQuery(ctx context.Context, query *BaseSelectQuery) ([]interfac

clause, args := selectQuery.ToSQL()

span, ctx := opentracingkit.MaybeStartSpanFromContext(ctx, fmt.Sprintf("thunder.sqlgen.BaseQuery(%s)", selectQuery.Table))
defer span.Finish()
span.SetTag("query", clause)
span.SetTag("queryVariables", args)

res, err := db.QueryExecer(ctx).Query(clause, args...)
if err != nil {
opentracingkit.LogError(span, err)
return nil, err
}
defer res.Close()
Expand All @@ -136,23 +120,7 @@ func (db *DB) BaseQuery(ctx context.Context, query *BaseSelectQuery) ([]interfac
func (db *DB) execWithTrace(ctx context.Context, query SQLQuery, operationName string) (sql.Result, error) {
clause, args := query.ToSQL()

span, ctx := opentracingkit.MaybeStartSpanFromContext(ctx, fmt.Sprintf("thunder.sqlgen.%s", operationName))
defer span.Finish()

span.SetTag("query", clause)
span.SetTag("queryVariables", args)

result, err := db.QueryExecer(ctx).Exec(clause, args...)
if err != nil {
opentracingkit.LogError(span, err)
return nil, err
}

if rows, err := result.RowsAffected(); err != nil {
span.SetTag("rowsAffected", rows)
}

return result, err
return db.QueryExecer(ctx).Exec(clause, args...)
}

// Query fetches a collection of rows from the database
Expand Down