This repository has been archived by the owner on Dec 1, 2020. It is now read-only.
Update log appearance for application controller #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the replacement commit fixes a typo in the original |
- it provides little information to a reader of the log message - it doesn't follow go community conventions for log messages To improve the message this adds information to the message and sets the first letter to lower case. Incidentally, this also adds return values to the adjacent bare return. closes #24 Signed-off-by: Mark Ayers mark@philoserf.com
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing log result has two issues:
To improve the message this adds information to the message and
sets the first letter to lower case. Incidentally, this also adds return
values to the adjacent bare return.
closes #24
Signed-off-by: Mark Ayers mark@philoserf.com
NOTE for Reviewers: I had considered removing the log message. I am not certain that adding more context to the message improves what will still be a potentially long set of log messages. See the example in the referenced issue for an example.