Implement proper async call of sagas #51
Labels
Comments
|
@malave when I select a domain in the intent list page the list doesn't always load is that related? Also the client error console fills up with every time I navigate to a list page. Is that related? |
|
I created #59 just in case |
|
Errors reported by @dcalvom:
|
malave
added a commit
that referenced
this issue
Jan 16, 2018
- Changed Dockerfiles to be more efficient by properly caching `node_modules` when necessary References: #51
malave
added a commit
that referenced
this issue
Jan 16, 2018
… correctly and causing an error if another element in the same position was deleted References: #51
malave
added a commit
that referenced
this issue
Jan 17, 2018
- [x] When you create an agent the redirect is to http://localhost:3500/wizard/entity-intent instead of http://localhost:3500/wizard/domain - [x] The combo of domains in the intent list page was loaded, but was once you pick any domain the intents list isn't loaded. If you click again in the `intents` - link in the menu the domain list goes empty - [x] AgentName is not being filled in the webhook request - [x] The intent post doesn't have the intent name inlcuded. In the past once the intent was created the reference to the id was pssed - [x] Delete agent doesn't works - [x] Delete domain, intent and entity doesn't works (I don't know if this is already implemented) Reference #51
malave
added a commit
that referenced
this issue
Jan 17, 2018
… correctly and causing an error if another element in the same position was deleted - Added changes suggested by @dcalvom - Changed Dockerfiles to be more efficient by properly caching `node_modules` when necessary - Fixed configuration that made docker fail to build - Correctly called generator function in sagas to be async - When the API creates an agent the id is a number instead of a string like everywhere else, this is fixed - Fixed error in converse where it didn't call the API correctly - Correctly handle of rejected promises in sagas after doing the refactoring - Refactored all sagas to use the swagger middleware - Modified sagas to use `API_URL` environment variable - Added `dotenv-webpack` plug in to load env variables from `.env` file if available - Modified compose file to pass API url variable to container Errors reported by @dcalvom: - [x] When you create an agent the redirect is to http://localhost:3500/wizard/entity-intent instead of http://localhost:3500/wizard/domain - [x] The combo of domains in the intent list page was loaded, but was once you pick any domain the intents list isn't loaded. If you click again in the `intents` - link in the menu the domain list goes empty - [x] AgentName is not being filled in the webhook request - [x] The intent post doesn't have the intent name inlcuded. In the past once the intent was created the reference to the id was pssed - [x] Delete agent doesn't works - [x] Delete domain, intent and entity doesn't works (I don't know if this is already implemented) Reference: #48, #51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now where are mostly calling an action, wait for the response and then either update the UI or redirect.
There are a few cases where another saga must be call and I had to perform some work arounds but there are some cases where this just created am unexpected behavior.
According to the redux page we could use
redux-thunkor other libraries.Redux Sagas is supposed to be able to handle this but so far I haven't been successful doing this.
The purpose of this issue is to investigate how to perform this with sagas or other libraries. Also part of the implementation should stop the rest of the actions after an error.
Here are the scenarios that I found so far:
/(currently the redirect doesn't work and sometime the agent list doesn't populate)The text was updated successfully, but these errors were encountered: