Product review committee changes v1 #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes have been made in response to the first PRC for refget. This includes - Adding a better description to the problem the specification is solving - Clarification of the OpenAPI schema - Improving text in protocol essentials (Range and query parameters are allowed) - Adding an example to `/sequence/<id>` - What happens when start and end are the same value (a zero length string is returned) - Adding Reece Hart as a contributor - Typos
|
First set of changes now in. We have a couple more changes to discuss before we okay this |
Circular chromosomes are a potential issue as to create the checksum it must have a start and an end i.e. a break-point in the circular DNA. This is out of scope for this specification and we expect other authorities to have made that call for us i.e. a submitter to an INSDC archive will have to make this call.
Creating a section about compliance and how to test
PRC noted that nothing in the spec limits refget to just nucleotide sequences. This has been clarified in the design principles
Switch to using 406 for bad content types. Also better descriptions of how to handle the different content types
|
Going to merge this ahead of the announcement today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications related to the first PRC
Changes have been made in response to the first PRC for refget. This includes
/sequence/<id>