Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor typo in VCF specs #652

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Conversation

kojix2
Copy link
Contributor

@kojix2 kojix2 commented Jun 12, 2022

Dear hts-spec team. Hello.

I was reading hts-spec's 5.4 Specifying complex rearrangements with breakends today, and I am reporting that I have found what appears to be a minor typo.

Have a nice day.

@hts-specs-bot
Copy link

Changed PDFs as of 4ed2a46: VCFv4.1 (diff), VCFv4.2 (diff). This link will expire in 30 days

@d-cameron
Copy link
Contributor

d-cameron commented Jun 20, 2022

This typo was fixed in VCF 4.3. We will discuss whether we should be fixing typos in old versions of the specifications in the next GA4GH File Formats meeting (The next one is 2022-06-21 2100 GMT. They are public meetings and you are welcome to join and contribute). Generally speaking, we don't backport clarification to all earlier versions of the specifications and leave published specifications as-is.

@kojix2
Copy link
Contributor Author

kojix2 commented Jun 20, 2022

Thank you @d-cameron.

I recently used VirusBreakend with docker, and the Kraken2 database uses genotype D HBV sequences by default, but since genotype B and genotype C are more common in Asia, accurate breakpoints may not be detectable, and I wanted to replace the HBV sequences, but I did not know how to do it.

I'm sorry I got sidetracked.

I didn't notice v4.3 because v4.2 is the first thing that comes up in a Google search.
If it is fixed in the latest version, then it seems to be fine.
Should I close this issue?

@d-cameron d-cameron merged commit f2dbeb3 into samtools:master Jun 21, 2022
@d-cameron
Copy link
Contributor

Our general policy is to backport to 4.2 (since that's still the version officially supported by htsjdk). Too small a change to worry about splitting up. Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants